Add MODEL-CARBON-01 rule to prevent Carbon casts in models

Remove auto-generated tests and .expect files 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
2025-12-25 21:04:36 +00:00
parent 29c657f7a7
commit 1322bbf988
18 changed files with 335 additions and 120 deletions
--- a/app/RSpade/Core/Api/Api_Key_Model.php
+++ b/app/RSpade/Core/Api/Api_Key_Model.php
@@ -33,7 +33,7 @@ use App\RSpade\Core\Models\User_Model;
 */
 /**
 * _AUTO_GENERATED_ Database type hints - do not edit manually
- * Generated on: 2025-12-10 02:59:31
+ * Generated on: 2025-12-25 20:57:53
 * Table: _api_keys
 *
 * @property int $id
@@ -53,7 +53,7 @@ use App\RSpade\Core\Models\User_Model;
 * @mixin \Eloquent
 */
 class Api_Key_Model extends Rsx_System_Model_Abstract
- {
+  {
    protected $table = '_api_keys';

    public static $enums = [];
--- a/app/RSpade/Core/Files/File_Attachment_Model.php
+++ b/app/RSpade/Core/Files/File_Attachment_Model.php
@@ -30,42 +30,51 @@ use App\RSpade\Core\Files\File_Storage_Model;
 * provides the basic structure for categorizing uploaded files.
 */

-
 /**
- * _AUTO_GENERATED_
- * @property integer $id
- * @property string $key
- * @property integer $file_storage_id
- * @property string $file_name
- * @property string $file_extension
- * @property integer $file_type_id
- * @property integer $width
- * @property integer $height
- * @property integer $duration
- * @property boolean $is_animated
- * @property integer $frame_count
- * @property string $fileable_type
- * @property integer $fileable_id
- * @property string $fileable_category
- * @property string $fileable_type_meta
- * @property integer $fileable_order
+ * _AUTO_GENERATED_ Database type hints - do not edit manually
+ * Generated on: 2025-12-25 20:57:54
+ * Table: _file_attachments
+ *
+ * @property int $id
+ * @property mixed $key
+ * @property int $file_storage_id
+ * @property mixed $file_name
+ * @property mixed $file_extension
+ * @property int $file_type_id
+ * @property int $width
+ * @property int $height
+ * @property int $duration
+ * @property bool $is_animated
+ * @property int $frame_count
+ * @property mixed $fileable_type
+ * @property int $fileable_id
+ * @property mixed $fileable_category
+ * @property mixed $fileable_type_meta
+ * @property int $fileable_order
 * @property string $fileable_meta
- * @property integer $site_id
- * @property string $session_id
- * @property \Carbon\Carbon $created_at
- * @property \Carbon\Carbon $updated_at
- * @property integer $created_by
- * @property integer $updated_by
- * @method static mixed file_type_id_enum()
- * @method static mixed file_type_id_enum_select()
- * @method static mixed file_type_id_enum_ids()
- * @property-read mixed $file_type_id_constant
- * @property-read mixed $file_type_id_label
+ * @property int $site_id
+ * @property mixed $session_id
+ * @property string $created_at
+ * @property string $updated_at
+ * @property int $created_by
+ * @property int $updated_by
+ *
+ * @property-read string $file_type_id_label
+ * @property-read string $file_type_id_constant
+ * @property-read array $file_type_id_enum_val
+ *
+ * @method static array file_type_id_enum_val() Get all enum definitions with full metadata
+ * @method static array file_type_id_enum_select() Get selectable items for dropdowns
+ * @method static array file_type_id_enum_labels() Get simple id => label map
+ * @method static array file_type_id_enum_ids() Get array of all valid enum IDs
+ *
 * @mixin \Eloquent
 */
 class File_Attachment_Model extends Rsx_Site_Model_Abstract
-{
-    /** __AUTO_GENERATED: */
+ {
+    /**
+     * _AUTO_GENERATED_ Enum constants
+     */
    const FILE_TYPE_IMAGE = 1;
    const FILE_TYPE_ANIMATED_IMAGE = 2;
    const FILE_TYPE_VIDEO = 3;
@@ -73,6 +82,9 @@ class File_Attachment_Model extends Rsx_Site_Model_Abstract
    const FILE_TYPE_TEXT = 5;
    const FILE_TYPE_DOCUMENT = 6;
    const FILE_TYPE_OTHER = 7;
+
+    /** __AUTO_GENERATED: */
+
    /** __/AUTO_GENERATED */

    /**
--- a/app/RSpade/Core/Files/File_Storage_Model.php
+++ b/app/RSpade/Core/Files/File_Storage_Model.php
@@ -16,7 +16,7 @@ use App\RSpade\Core\Database\Models\Rsx_Model_Abstract;

 /**
 * _AUTO_GENERATED_ Database type hints - do not edit manually
- * Generated on: 2025-12-10 02:59:31
+ * Generated on: 2025-12-25 20:57:54
 * Table: _file_storage
 *
 * @property int $id
@@ -30,7 +30,7 @@ use App\RSpade\Core\Database\Models\Rsx_Model_Abstract;
 * @mixin \Eloquent
 */
 class File_Storage_Model extends Rsx_Model_Abstract
-    {
+     {
    // Required static properties from parent abstract class
    public static $enums = [];
    public static $rel = [];
--- a/app/RSpade/Core/Models/Country_Model.php
+++ b/app/RSpade/Core/Models/Country_Model.php
@@ -14,7 +14,7 @@ use App\RSpade\Core\Models\Region_Model;
 */
 /**
 * _AUTO_GENERATED_ Database type hints - do not edit manually
- * Generated on: 2025-12-10 02:59:31
+ * Generated on: 2025-12-25 20:57:54
 * Table: countries
 *
 * @property int $id
@@ -32,7 +32,7 @@ use App\RSpade\Core\Models\Region_Model;
 * @mixin \Eloquent
 */
 class Country_Model extends Rsx_Model_Abstract
-    {
+     {
    public static $enums = [];

    protected $table = 'countries';
--- a/app/RSpade/Core/Models/Ip_Address_Model.php
+++ b/app/RSpade/Core/Models/Ip_Address_Model.php
@@ -12,7 +12,7 @@ use App\RSpade\Core\Database\Models\Rsx_System_Model_Abstract;
 */
 /**
 * _AUTO_GENERATED_ Database type hints - do not edit manually
- * Generated on: 2025-12-10 02:59:31
+ * Generated on: 2025-12-25 20:57:54
 * Table: ip_addresses
 *
 * @property int $id
@@ -30,7 +30,7 @@ use App\RSpade\Core\Database\Models\Rsx_System_Model_Abstract;
 * @mixin \Eloquent
 */
 class Ip_Address_Model extends Rsx_System_Model_Abstract
-    {
+     {
    /**
     * Enum field definitions
     * @var array
--- a/app/RSpade/Core/Models/Login_User_Model.php
+++ b/app/RSpade/Core/Models/Login_User_Model.php
@@ -24,7 +24,7 @@ use App\RSpade\Core\Session\Session;
 */
 /**
 * _AUTO_GENERATED_ Database type hints - do not edit manually
- * Generated on: 2025-12-10 02:59:31
+ * Generated on: 2025-12-25 20:57:54
 * Table: login_users
 *
 * @property int $id
@@ -62,7 +62,7 @@ class Login_User_Model extends Rsx_Model_Abstract implements
    \Illuminate\Contracts\Auth\Authenticatable,
    \Illuminate\Contracts\Auth\Access\Authorizable,
    \Illuminate\Contracts\Auth\CanResetPassword
-     {
+      {
    /**
     * _AUTO_GENERATED_ Enum constants
     */
--- a/app/RSpade/Core/Models/Region_Model.php
+++ b/app/RSpade/Core/Models/Region_Model.php
@@ -14,7 +14,7 @@ use App\RSpade\Core\Models\Country_Model;
 */
 /**
 * _AUTO_GENERATED_ Database type hints - do not edit manually
- * Generated on: 2025-12-10 02:59:32
+ * Generated on: 2025-12-25 20:57:54
 * Table: regions
 *
 * @property int $id
@@ -31,7 +31,7 @@ use App\RSpade\Core\Models\Country_Model;
 * @mixin \Eloquent
 */
 class Region_Model extends Rsx_Model_Abstract
-    {
+     {
    public static $enums = [];

    protected $table = 'regions';
--- a/app/RSpade/Core/Models/Site_Model.php
+++ b/app/RSpade/Core/Models/Site_Model.php
@@ -14,7 +14,7 @@ use App\RSpade\Core\Models\User_Model;
 */
 /**
 * _AUTO_GENERATED_ Database type hints - do not edit manually
- * Generated on: 2025-12-10 02:59:32
+ * Generated on: 2025-12-25 20:57:55
 * Table: sites
 *
 * @property int $id
@@ -31,7 +31,7 @@ use App\RSpade\Core\Models\User_Model;
 * @mixin \Eloquent
 */
 class Site_Model extends Rsx_Model_Abstract
-     {
+      {
    use SoftDeletes;

    /**
--- a/app/RSpade/Core/Models/User_Invite_Model.php
+++ b/app/RSpade/Core/Models/User_Invite_Model.php
@@ -12,7 +12,7 @@ use App\RSpade\Core\Database\Models\Rsx_Site_Model_Abstract;
 */
 /**
 * _AUTO_GENERATED_ Database type hints - do not edit manually
- * Generated on: 2025-12-10 02:59:32
+ * Generated on: 2025-12-25 20:57:55
 * Table: user_invites
 *
 * @property int $id
@@ -28,7 +28,7 @@ use App\RSpade\Core\Database\Models\Rsx_Site_Model_Abstract;
 * @mixin \Eloquent
 */
 class User_Invite_Model extends Rsx_Site_Model_Abstract
-     {
+      {
    /**
     * Enum field definitions
     * @var array
--- a/app/RSpade/Core/Models/User_Model.php
+++ b/app/RSpade/Core/Models/User_Model.php
@@ -23,41 +23,47 @@ use App\RSpade\Core\Models\User_Profile_Model;
 * See: php artisan rsx:man acls
 */

-
 /**
- * _AUTO_GENERATED_
- * @property integer $id
- * @property integer $login_user_id
- * @property integer $site_id
- * @property string $first_name
- * @property string $last_name
- * @property string $phone
- * @property integer $role_id
- * @property boolean $is_enabled
- * @property integer $user_role_id
- * @property string $email
- * @property \Carbon\Carbon $deleted_at
- * @property \Carbon\Carbon $created_at
- * @property \Carbon\Carbon $updated_at
- * @property integer $created_by
- * @property integer $updated_by
- * @property integer $deleted_by
- * @property string $invite_code
- * @property \Carbon\Carbon $invite_accepted_at
- * @property \Carbon\Carbon $invite_expires_at
- * @method static mixed role_id_enum()
- * @method static mixed role_id_enum_select()
- * @method static mixed role_id_enum_ids()
- * @property-read mixed $role_id_constant
- * @property-read mixed $role_id_label
- * @property-read mixed $role_id_permissions
- * @property-read mixed $role_id_can_admin_roles
- * @property-read mixed $role_id_selectable
+ * _AUTO_GENERATED_ Database type hints - do not edit manually
+ * Generated on: 2025-12-25 20:57:55
+ * Table: users
+ *
+ * @property int $id
+ * @property int $login_user_id
+ * @property int $site_id
+ * @property mixed $first_name
+ * @property mixed $last_name
+ * @property mixed $phone
+ * @property int $role_id
+ * @property bool $is_enabled
+ * @property int $user_role_id
+ * @property mixed $email
+ * @property string $deleted_at
+ * @property string $created_at
+ * @property string $updated_at
+ * @property int $created_by
+ * @property int $updated_by
+ * @property int $deleted_by
+ * @property mixed $invite_code
+ * @property string $invite_accepted_at
+ * @property string $invite_expires_at
+ *
+ * @property-read string $role_id_label
+ * @property-read string $role_id_constant
+ * @property-read array $role_id_enum_val
+ *
+ * @method static array role_id_enum_val() Get all enum definitions with full metadata
+ * @method static array role_id_enum_select() Get selectable items for dropdowns
+ * @method static array role_id_enum_labels() Get simple id => label map
+ * @method static array role_id_enum_ids() Get array of all valid enum IDs
+ *
 * @mixin \Eloquent
 */
 class User_Model extends Rsx_Site_Model_Abstract
-{
-    /** __AUTO_GENERATED: */
+ {
+    /**
+     * _AUTO_GENERATED_ Enum constants
+     */
    const ROLE_DEVELOPER = 100;
    const ROLE_ROOT_ADMIN = 200;
    const ROLE_SITE_OWNER = 300;
@@ -66,6 +72,9 @@ class User_Model extends Rsx_Site_Model_Abstract
    const ROLE_USER = 600;
    const ROLE_VIEWER = 700;
    const ROLE_DISABLED = 800;
+
+    /** __AUTO_GENERATED: */
+
    /** __/AUTO_GENERATED */

    // =========================================================================
--- a/app/RSpade/Core/Models/User_Permission_Model.php
+++ b/app/RSpade/Core/Models/User_Permission_Model.php
@@ -7,7 +7,7 @@ use App\RSpade\Core\Models\User_Model;

 /**
 * _AUTO_GENERATED_ Database type hints - do not edit manually
- * Generated on: 2025-12-10 02:59:32
+ * Generated on: 2025-12-25 20:57:55
 * Table: user_permissions
 *
 * @property int $id
@@ -22,7 +22,7 @@ use App\RSpade\Core\Models\User_Model;
 * @mixin \Eloquent
 */
 class User_Permission_Model extends Rsx_Model_Abstract
- {
+  {
    protected $table = 'user_permissions';
    protected $fillable = []; // No mass assignment - always explicit

--- a/app/RSpade/Core/Models/User_Profile_Model.php
+++ b/app/RSpade/Core/Models/User_Profile_Model.php
@@ -35,7 +35,7 @@ use App\RSpade\Core\Models\User_Model;
 */
 /**
 * _AUTO_GENERATED_ Database type hints - do not edit manually
- * Generated on: 2025-12-10 02:59:32
+ * Generated on: 2025-12-25 20:57:55
 * Table: user_profiles
 *
 * @property int $id
@@ -51,7 +51,7 @@ use App\RSpade\Core\Models\User_Model;
 * @mixin \Eloquent
 */
 class User_Profile_Model extends Rsx_Model_Abstract
-    {
+     {
    /**
     * The table associated with the model
     *
--- a/app/RSpade/Core/Models/User_Verification_Model.php
+++ b/app/RSpade/Core/Models/User_Verification_Model.php
@@ -11,33 +11,45 @@ use App\RSpade\Core\Database\Models\Rsx_Model_Abstract;
 * and two-factor authentication via email or SMS.
 */

-
 /**
- * _AUTO_GENERATED_
- * @property integer $id
- * @property string $email
- * @property string $verification_code
- * @property integer $verification_type_id
- * @property \Carbon\Carbon $verified_at
- * @property \Carbon\Carbon $expires_at
- * @property \Carbon\Carbon $created_at
- * @property \Carbon\Carbon $updated_at
- * @property integer $created_by
- * @property integer $updated_by
- * @method static mixed verification_type_id_enum()
- * @method static mixed verification_type_id_enum_select()
- * @method static mixed verification_type_id_enum_ids()
- * @property-read mixed $verification_type_id_constant
- * @property-read mixed $verification_type_id_label
+ * _AUTO_GENERATED_ Database type hints - do not edit manually
+ * Generated on: 2025-12-25 20:57:55
+ * Table: user_verifications
+ *
+ * @property int $id
+ * @property mixed $email
+ * @property mixed $verification_code
+ * @property int $verification_type_id
+ * @property string $verified_at
+ * @property string $expires_at
+ * @property string $created_at
+ * @property string $updated_at
+ * @property int $created_by
+ * @property int $updated_by
+ *
+ * @property-read string $verification_type_id_label
+ * @property-read string $verification_type_id_constant
+ * @property-read array $verification_type_id_enum_val
+ *
+ * @method static array verification_type_id_enum_val() Get all enum definitions with full metadata
+ * @method static array verification_type_id_enum_select() Get selectable items for dropdowns
+ * @method static array verification_type_id_enum_labels() Get simple id => label map
+ * @method static array verification_type_id_enum_ids() Get array of all valid enum IDs
+ *
 * @mixin \Eloquent
 */
 class User_Verification_Model extends Rsx_Model_Abstract
-{
-    /** __AUTO_GENERATED: */
+ {
+    /**
+     * _AUTO_GENERATED_ Enum constants
+     */
    const VERIFICATION_TYPE_EMAIL = 1;
    const VERIFICATION_TYPE_SMS = 2;
    const VERIFICATION_TYPE_EMAIL_RECOVERY = 3;
    const VERIFICATION_TYPE_SMS_RECOVERY = 4;
+
+    /** __AUTO_GENERATED: */
+
    /** __/AUTO_GENERATED */

    /**
--- a/app/RSpade/Core/Search/Search_Index_Model.php
+++ b/app/RSpade/Core/Search/Search_Index_Model.php
@@ -17,7 +17,7 @@ use App\RSpade\Core\Database\Models\Rsx_Site_Model_Abstract;

 /**
 * _AUTO_GENERATED_ Database type hints - do not edit manually
- * Generated on: 2025-12-10 02:59:32
+ * Generated on: 2025-12-25 20:57:55
 * Table: _search_indexes
 *
 * @property int $id
@@ -37,7 +37,7 @@ use App\RSpade\Core\Database\Models\Rsx_Site_Model_Abstract;
 * @mixin \Eloquent
 */
 class Search_Index_Model extends Rsx_Site_Model_Abstract
-    {
+     {
    // Required static properties from parent abstract class
    public static $enums = [];
    public static $rel = [];
--- a/app/RSpade/Core/Session/Session.php
+++ b/app/RSpade/Core/Session/Session.php
@@ -41,7 +41,7 @@ use App\RSpade\Core\Session\User_Agent;
 */
 /**
 * _AUTO_GENERATED_ Database type hints - do not edit manually
- * Generated on: 2025-12-10 02:59:33
+ * Generated on: 2025-12-25 20:57:55
 * Table: _sessions
 *
 * @property int $id
@@ -63,7 +63,7 @@ use App\RSpade\Core\Session\User_Agent;
 * @mixin \Eloquent
 */
 class Session extends Rsx_System_Model_Abstract
-    {
+     {
    // Enum definitions (required by abstract parent)
    public static $enums = [];